RDKB-60436 : Develop Code. #66
Conversation
Reason for change: RDKB-59763 - Develop that US acceptance criteria. Test Procedure: Build should passed WANManager functionality should work without any issue Risks: Medium Signed-off-by: LakshminarayananShenbagaraj <[email protected]>
|
|
There was a problem hiding this comment.
Pull Request Overview
This PR implements WAN Manager status event handling via RBUS to trigger network response scripts based on WAN connectivity changes. It subscribes to WAN status events and executes appropriate network response actions when the WAN interface transitions to "Up" state or other conditions.
Key Changes:
- Added RBUS event subscription for WAN Manager current status changes
- Implemented event handler to trigger network_response.sh script based on WAN status
- Enhanced network_response.sh to check for Hotspot interface availability in addition to LTE
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cosa_rbus_handler_apis.h | Added WAN Manager status TR181 parameter definition and function declaration for WAN status event subscription |
| cosa_rbus_handler_apis.c | Implemented WAN status event handler and subscription logic to trigger network response scripts |
| network_response.sh | Added Hotspot interface availability check alongside existing LTE interface check |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| if (eventName == NULL) | ||
| { | ||
| CcspTraceError(("%s %d : FAILED , value is NULL\n",__FUNCTION__, __LINE__)); |
There was a problem hiding this comment.
The error message "value is NULL" is ambiguous. It would be clearer to specify which value is NULL, e.g., "event name is NULL" to match the clarity of the other error messages in this function.
| CcspTraceError(("%s %d : FAILED , value is NULL\n",__FUNCTION__, __LINE__)); | |
| CcspTraceError(("%s %d : FAILED , event name is NULL\n",__FUNCTION__, __LINE__)); |
| #endif | ||
|
|
||
| #if defined(RBUS_BUILD_FLAG_ENABLE) && !defined(_HUB4_PRODUCT_REQ_) && !defined(RDKB_EXTENDER_ENABLED) | ||
| //Subscribe WAN Status Event |
There was a problem hiding this comment.
Inconsistent indentation: This line uses spaces for indentation while the rest of the function uses tabs. For consistency with the surrounding code, this should use tabs instead of spaces.
| //Subscribe WAN Status Event | |
| //Subscribe WAN Status Event |
Reason for change:
RDKB-59763 - Develop that US acceptance criteria.
Test Procedure:
Build should passed
WANManager functionality should work without any issue
Risks: Medium